software design - Dependency injection OR configuration object? -

-

i have following constructor class

 public myclass(file f1, file f2, file f3, class1 c1, class2 c2, class3 c3) { .......... }

as can seen, has 6 parameters. on seeing code, 1 of seniors said instead of passing 6 parameters should rather pass configuration object.

i wrote code way because have read "dependency injection", says "classes must ask want". think passing configuration object against principle.

is interpretation of "dependency injection" correct? or should take senior's advice?

"configuration object" obtuse term apply in situation; frames efforts in purely mechanical sense. goal communicate intent class's consumer; let's refactor toward that.

methods or constructors numerous parameters indicate loose relationship between them. consumer has make more inferences understand api. special these 3 files these 3 classes? information not being communicated.

this opportunity create more meaningful , intention-revealing interface extracting explicit concept implicit one. example, if 3 files related because of user, userfileset parameter express that. perhaps f1 related c1, f2 c2, , f3 c3. declaring associations independent classes halve parameter count , increase amount of information can derived api.

ultimately, refactoring highly dependent on problem domain. don't assume should create single object fulfill parameter list; try refactor along contours of relationships between parameters. yield code reflects problem solves more language used solve it.


Comments

Post a Comment

Popular posts from this blog

ASP.NET/SQL find the element ID and update database -

-
basically i've got update query runs when click submit button. i have asp:repeater in page layer inside this <asp:repeater id="dgbookings" runat="server" onitemdatabound="itemdb"> <itemtemplate> <div class="bookingscontent"> <div class="bookingdetails" id="<%# databinder.eval(container.dataitem, "booking_ref") %>"> <p class="infotext"><%# databinder.eval(container.dataitem, "adults") %> <asp:linkbutton onclick="editdetails" text="edit..." runat="server"></asp:linkbutton></p> <p class="infotext"><asp:linkbutton onclick="submitdetails" text="submit..." runat="server"></asp:linkbutton></p> </div> </div> </itemtemplate> <asp:repeater> and outputs ...
Read more

jquery - appear modal windows bottom -

-
i have modal windows in application, work fine <div id="modal" class="modal hide fade" tabindex="-1" role="dialog" aria-labelledby="mymodallabel" aria-hidden="true"> but when modal appears, appear top of windows, , want appear bottom the application joomla 3.0! , using template of meet gavern any idea? i found solution i modified de css in bootstrap .modal.fade { top:-25%; -webkit-transition:opacity .3s linear, bottom .3s ease-out; -moz-transition:opacity .3s linear, bottom .3s ease-out; -ms-transition:opacity .3s linear, bottom .3s ease-out; -o-transition:opacity .3s linear, bottom .3s ease-out; transition:opacity .3s linear, bottom .3s ease-out; }
Read more

c++ - Compiling static TagLib 1.6.3 libraries for Windows -

-
i having super hard time compiling , using taglib 1.6.3 in qt project. i've tried can think of. taglib claims supported through cmake i'm not having luck. furthermore, i'm confused kinds of files need qt libs! i've built *.a files, *.lib, , *.dll. understand far... believe since i'm working in windows *.lib want. no matter do, end "undefined references" taglib functions try use when try compile qt project. have tried mingw32, msys, visual studio 2008, , cross-compiling windows on linux. turning nothing. what makes less sense me if compile same taglib source qt on mac (g++ think?) works fine! somewhere in windows compilation procedures have going wrong. have been smacking face on desk 30 (on , off) hours trying figure out. since qt uses mingw must compile taglib same compiler? if compile *.lib's visual studio not compatible? are *.a libraries usable in windows? (assuming mingw) i'm still trying handle on c++ stuff, after reading coun...
Read more